Skip to content

Add a table of contents to readme.md #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Add a table of contents to readme.md #5235

merged 1 commit into from
Jan 20, 2021

Conversation

Programazing
Copy link
Contributor

I believe this would make navigating the readme much easier.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 5, 2021

💚 CLA has been signed

@Programazing
Copy link
Contributor Author

I have no idea why this failed. It was forked from master and the PR is against master. I can't imagine what could have changed in the ten minutes it took me to make a change to a single markdown file.

@stevejgordon
Copy link
Contributor

Thanks for submitting this @Programazing. Sorry it's taken me so long to get to this review. Don't worry about the tests, those are unrelated. This change makes sense to me. I'm gonna pull it in!

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevejgordon stevejgordon merged commit 0c823ca into elastic:master Jan 20, 2021
stevejgordon pushed a commit that referenced this pull request Jan 21, 2021
stevejgordon pushed a commit that referenced this pull request Jan 21, 2021
stevejgordon added a commit that referenced this pull request Jan 23, 2021
(cherry picked from commit 0c823ca)

Co-authored-by: Christopher C. Johnson <chris@thatamazingprogrammer.com>
stevejgordon added a commit that referenced this pull request Jan 23, 2021
(cherry picked from commit 0c823ca)

Co-authored-by: Christopher C. Johnson <chris@thatamazingprogrammer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants