Implement version field type #5200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Dec 28, 2020
There was a problem hiding this comment.
Almost there one failing test on parity:
[xUnit.net 00:00:24.7659600] Tests.Mapping.PropertyDescriptorTests.IPropertiesDescriptorImplementsAllPropertyMethodsOfPropertiesDescriptor [FAIL]
Failed Tests.Mapping.PropertyDescriptorTests.IPropertiesDescriptorImplementsAllPropertyMethodsOfPropertiesDescriptor [25 ms]
Error Message:
Expected concreteMethodNames.Except(interfaceMethodNames) to be empty, but found {"Version"}.
Stack Trace:
at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
at FluentAssertions.Execution.GivenSelector`1.FailWith(String message, Object[] args)
at FluentAssertions.Execution.GivenSelector`1.FailWith(String message, Func`2[] args)
at FluentAssertions.Collections.CollectionAssertions`2.BeEmpty(String because, Object[] becauseArgs)
at Tests.Mapping.PropertyDescriptorTests.IPropertiesDescriptorImplementsAllPropertyMethodsOfPropertiesDescriptor() in D:\a\1\s\tests\Tests\Mapping\PropertyDescriptorTests.cs:line 42
FieldTypes.Version is indeed a conundrum. Don't think a clean option exists. ++ to DocVersion in 8 for _version.
|
Thanks @Mpdreamz. I've fixed up the interface causing the failure. Will allow the tests to run in CI and then merge if that's all good. |
Mpdreamz
requested changes
Jan 6, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Implement version field type * Fix failing test * Add skip version to test
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Implement version field type * Fix failing test * Add skip version to test
stevejgordon
added a commit
that referenced
this pull request
Jan 7, 2021
stevejgordon
added a commit
that referenced
this pull request
Jan 11, 2021
* Implement version field type (#5200) * Implement version field type * Fix failing test * Add skip version to test * Fixup namespace for master Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mpdreamz I've attempted this by reviewing previous PRs and a bit of sleuthing! Please let me know if I've missed anything. I've been able to use the mapping on a test project.
Main challenge in naming in
FieldCapabilitiessince that already has the concept of the "_version" field. I welcome opinions on the naming. Perhaps in 8.0 we can consider renaming both of these so thatVersionbecomesDocVersion?