Skip to content

[Docs] order anchor-list output explicitly. #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

Mpdreamz
Copy link
Member

anchor-list output was not explicitly ordered causing issues with different itteration orders of files/directories between OS's.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Mpdreamz!

@russcam
Copy link
Contributor

russcam commented Jul 31, 2020

integration test failures not related to this change (will open separate issue).

@russcam russcam merged commit 6b3aed2 into master Jul 31, 2020
@russcam russcam deleted the fix/docs/order-anchor-links branch July 31, 2020 01:32
@github-actions
Copy link
Contributor

The backport to 6.x failed:

The process 'git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.x 6.x
# Navigate to the new working tree
cd .worktrees/backport-6.x
# Create a new branch
git switch --create backport-4894-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6b3aed2d2e8b136e21be9e374bd5aa2b78af4e4f
# Push it to GitHub
git push --set-upstream origin backport-4894-to-6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.x

Then, create a pull request where the base branch is 6.x and the compare/head branch is backport-4894-to-6.x.

github-actions bot pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs
github-actions bot pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs
russcam pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs
russcam pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
russcam pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs
russcam pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
russcam pushed a commit that referenced this pull request Jul 31, 2020
* Make sure anchor-links output is explicitly ordered as well
* update docs

(cherry picked from commit 6b3aed2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants