Skip to content

AutoDateHistogramAggregate Interval should be DateMathTime #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 2, 2020

This commit fixes a bug with AutoDateHistogramAggregate Interval
property that uses the Time type to represent valid intervals. The Time
type however does not support Months and Years, which are valid units
for the AutoDateHistogram interval.

Fixes #4333

This commit fixes a bug with AutoDateHistogramAggregate Interval
property that uses the Time type to represent valid intervals. The Time
type however does not support Months and Years, which are valid units
for the AutoDateHistogram interval.

Fixes #4333
@russcam
Copy link
Contributor Author

russcam commented Jun 2, 2020

Requires manual porting to 7.x, 7.8 and 6.x because the Interval property will need to be kept for backwards binary compatibility, and a new property introduced

@russcam russcam merged commit a693da3 into master Jun 10, 2020
@russcam russcam deleted the fix/4333 branch June 10, 2020 04:13
russcam added a commit that referenced this pull request Jun 10, 2020
This commit fixes a bug with AutoDateHistogramAggregate Interval
property that uses the Time type to represent valid intervals. The Time
type however does not support Months and Years, which are valid units
for the AutoDateHistogram interval.

Fixes #4333

(cherry picked from commit a693da3)
russcam added a commit that referenced this pull request Jun 10, 2020
This commit fixes a bug with AutoDateHistogramAggregate Interval
property that uses the Time type to represent valid intervals. The Time
type however does not support Months and Years, which are valid units
for the AutoDateHistogram interval.

Fixes #4333

(cherry picked from commit a693da3)
russcam added a commit that referenced this pull request Jun 10, 2020
This commit fixes a bug with AutoDateHistogramAggregate Interval
property that uses the Time type to represent valid intervals. The Time
type however does not support Months and Years, which are valid units
for the AutoDateHistogram interval.

Fixes #4333

(cherry picked from commit a693da3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonConverter error with AutoDateHistogram aggregation
2 participants