Correction of the the unit option for the GeoDistance filter (changed fr... #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from 'distance_unit' to 'unit')
Mpdreamz
added a commit
that referenced
this pull request
Oct 28, 2013
Correction of the the unit option for the GeoDistance filter (changed fr...
|
Ty for submitting this PR @gmarz and thanks for linking to the appropiate elasticsearch issue 👍 |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the unit option on the GeoDistance filter. There was an error in the Elasticsearch documentation stating that the parameter for specifying the distance unit was "distance_unit", however it is actually just "unit". This has since been corrected (See: elastic/elasticsearch#2771), but NEST was using the incorrect "distance_unit" parameter. Before this change, specifying the distance unit would cause Elasticsearch to throw a parsing exception. I've tested and confirmed this change in my application and have updated the unit test accordingly.