Skip to content

Allow appending custom querystring parameters #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2013

Conversation

alhardy
Copy link
Contributor

@alhardy alhardy commented May 15, 2013

We are using a custom OAUTH implementation to authenticate with elastic search via a token passed as a query string parameter.

The changes in the two commits just allow ConnectionSettings to be instantiated with a NameValueCollection whose key values are appended to the connection URI as query string parameters.

@Mpdreamz
Copy link
Member

Hi @alhardy

Many thanks for this PR and sorry for not getting on this quicker! It will probably be another couple of days before I can review and pull.

@Mpdreamz Mpdreamz merged commit d3756e5 into elastic:master May 27, 2013
@Mpdreamz
Copy link
Member

I merged this in the master but with the following changes:

  • Removed the second constructor, call SetGlobalRequestParameters(NameValueCollection q) on ConnectionSettings instead.
  • The unit tests for copy key test failed as they were written source.CopyKeyValues(dest) but they were implemented as dest.CopyKeyValues(source); I liked the unit tests version better so i changed the implementation.

Thanks @alhardy :)

@alhardy
Copy link
Contributor Author

alhardy commented May 27, 2013

Great thank you. When will these code changes be available via nuget?

@Mpdreamz Mpdreamz mentioned this pull request Jun 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants