Feature/percolate query #2063
Merged
Feature/percolate query #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public static class IdExtensions | ||
| { | ||
| public static bool IsConditionless(this Id id) |
There was a problem hiding this comment.
Should we make these extensions internal? Not just this one in particular, but any IsCondtionless() extension (i.e. TypeName.IsConditionless()).
|
Few minor nitpicks but overall LGTM 👍 . I'm +1 on |
Split doc_values out into separate interface Set the Accept header using requestData.Accept property Closes #2007
russcam
force-pushed
the
feature/percolate-query
branch
from
cfbbb98 to
007ba5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2007
@Mpdreamz, I see that you already fixed the percolate stats changes in c5b71db 👍
@gmarz, @Mpdreamz , What are your thoughts on
ICoreProperty? Basically, thepercolatortype only needs name, type name and index name so these remain onIPropertyand pushed the remaining properties up intoICoreProperty.Maybe
IAnalyzablePropertymight be better, as the properties relate to analysis?