Add support for _license related API's #2034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- License.LoadFromDisk(path) - Backported elasticsearch node improvements from master branch - Added bat file generations for the various clusters, allows you to manually start one of our test clusters with the right settings - Make sure tests that inherit ApiTestBase directly do not use a "real" client in `mixed` testing mode - Validate license information on startup, if this fails all tests fails. From the commandline we always start a fresh cluster so the trial license'll stay valid. If you manually start a node with no license but you have ES_LICENSE_FILE pointing to a license file we will try and register that.
|
|
||
| var exceptionMessageStart = "Server has license plugin installed, "; | ||
| var licenseFile = Environment.GetEnvironmentVariable("ES_LICENSE_FILE", EnvironmentVariableTarget.Machine); | ||
| if (!string.IsNullOrWhiteSpace(licenseFile)) |
There was a problem hiding this comment.
Should we also check for existence of the license here and continue if it isn't there?
|
One minor comment, otherwise LGTM 👍 |
|
Actually, nevermind my comment. I think it makes sense to throw the FileNotFound exception if ES_LICENSE_FILE is set. |
* authenticate * clear cached realms * roles * clear cached roles * delete role(s) * put role * get role(s) * user * delete user(s) * put user * get user(s) This also adds support for any request to be able to specify the `es-shield-runas-user` http header though the `RunAs` property on `RequestConfiguration` The OIS version of requests now directly exposes `RequestConfiguration`
Mpdreamz
force-pushed
the
feature/graph-api
branch
from
86bb34b to
d39b47e
Compare
|
Manually cherry-picked to 2.x and master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manually start one of our test clusters with the right settings
client in
mixedtesting modefails. From the commandline we always start a fresh cluster so the
trial license'll stay valid. If you manually start a node with no
license but you have
ES_LICENSE_FILEpointing to a license file we willtry and register that.