Add support for the Graph API that is part of xpack #2031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
changed the title
|
LGTM 👍 |
|
|
||
| public class GraphExploreControls : IGraphExploreControls | ||
| { | ||
| [JsonProperty("use_significance")] |
There was a problem hiding this comment.
I think we need the JsonProperty attributes only on the interface?
|
Just a couple of small things:
LGTM 👍 |
Include GraphExploreControls in integration test Remove JsonProperty attributes from GraphExploreControls
Mpdreamz
force-pushed
the
feature/graph-api
branch
from
86bb34b to
d39b47e
Compare
|
Manually cherry-picked to 2.x and master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.elastic.co/guide/en/graph/2.3/graph-introduction.html