fix #1980 GetAsync fails when specifying a null index. #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```csharp var response = await elasticClient.GetAsync<T>(id, s => s.Index(null)); ``` Would not default index back to inferred type of T. This PR makes specifying null for required route values a noop For optional routevalues null still clears the routevalue so the following still works ```csharp c => c.Index(project, i => i.Id(null)) ``` will reset the id on and send the index request to `/inferredindex/inferredtype`
|
LGTM |
gmarz
added a commit
that referenced
this pull request
Apr 12, 2016
The test was still relying on .Index(null) causing the index to be null.
Mpdreamz
pushed a commit
that referenced
this pull request
Apr 12, 2016
The test was still relying on .Index(null) causing the index to be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would not default index back to inferred type of T.
This PR makes specifying null for required route values a noop
For optional routevalues null still clears the routevalue so the
following still works
will reset the id on and send the index request to
/inferredindex/inferredtype