The task cancel API test was a bit flakey, #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was setting additional values in the integration setup on the class itself but this setup is run once for possibly multiple classes e.g EndpointUsage x; new TestClass(x).Test1(); new TestClass(x).Test2(); new TestClass(x).Test3(); new TestClass(x).Test4(); new TestClass(x).Test5(); integration setup is an override per TestClass but only one of them will be called per instance of `x`. So if the callback defines setting variables on the `TestClass` instance using `this` other TestClass instances won't see this. This PR makes CallIsolatedValues a class of its own that allows you to register extended values that can be shared amongst all TestClass instances.
| protected IDictionary<string, TaskId> SetupTaskIds { get; } = new Dictionary<string, TaskId>(); | ||
|
|
||
| protected override void BeforeAllCalls(IElasticClient client, IDictionary<ClientMethod, string> values) | ||
| protected override void IntegrationSetup(IElasticClient client, CallUniqueValues values) |
There was a problem hiding this comment.
I like the rename. Makes it clear that this is only applies to integration tests.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was setting additional values in the integration setup on the class
itself but this setup is run once for possibly multiple classes e.g
EndpointUsage x;
new TestClass(x).Test1();
new TestClass(x).Test2();
new TestClass(x).Test3();
new TestClass(x).Test4();
new TestClass(x).Test5();
integration setup is an override per TestClass but only one of them will
be called per instance of
x. So if the callback defines settingvariables on the
TestClassinstance usingthisother TestClassinstances won't see this.
This PR makes CallIsolatedValues a class of its own that allows you to
register extended values that can be shared amongst all TestClass
instances.