Default index is not used in query with 8.13.8 client

[jyrijh]

Elastic.Clients.Elasticsearch 8.13.8:

Elasticsearch version 8.8.1:

.NET runtime version 8.0.:

Operating system version Windows 11:

I updated the package reference to latest and my tests started to fail,

then from the SearchResponse.DebugInformation I found that the query had changed

8.12.1
{Valid Elasticsearch response built from a successful (200) low level call on POST: /articles_query_tests.%2A/_search

8.13.8
{Valid Elasticsearch response built from a successful (200) low level call on POST: /_search

Elastic.Clients.Elasticsearch.IElasticsearchClientSettings.DefaultIndex "articles_query_tests.*" is set in client.Transport in both versions.

But because i have a copy of articles_query_tests index with name my_articles.2023, query will return articles from both.

[jyrijh]

When I build the query I don't the .Index("indexname") as I wan't to use the DefaultIndex that is set when I create the client

string defaultIndex = "articles_query_tests.";

var settings = new ElasticsearchClientSettings(uri: new Uri(uri))
    .DefaultIndex($"{defaultIndex}*")

private SearchRequestDescriptor<Article> CreateSeachRequestDescriptor(int page, int size, int offset, Metadata.Models.Query.Search query)
{
    return CreateQuery(query)
        .TrackTotalHits(track)
        .From(page * offset)
        .Size(size)
        .Sort(CreateSortOptions(query));
}

[flobernd]

Hi @jyrijh, could you please share your CreateQuery method?

[jyrijh]

Sure, but it wont tell much

private SearchRequestDescriptor<Article> CreateQuery(Metadata.Models.Query.Search searchQuery)
{
    if (searchQuery.Filters.OfType<Metadata.Models.Query.Filter.IddocListFilter>().Any())
    {
        return CreateIdsQuery(searchQuery);
    }

    BoolQuery boolQuery = new()
    {
        Must = CreateMustQueries(searchQuery),
        Filter = CreateFilters(searchQuery),
        MustNot = CreateNotFilters(searchQuery)
    };

    SearchRequestDescriptor<Article> search = new();
    return search.Query(boolQuery);
}

[jyrijh]

and CreateMustQueries

private List<Query> CreateMustQueries(Metadata.Models.Query.Search searchQuery)
{
    List<Query> mustQueries = [];

    foreach (var filter in searchQuery.OrFilters.OfType<IHasValueOrDoesNotExistsFilter>())
    {
        if(filter is DateExistsFilter dateExistsFilter)
        {
            mustQueries.Add(new BoolQuery()
            {
                Should =
                [
                    CreateDateComparisonFilter(dateExistsFilter),
                    new BoolQuery()
                    {
                        MustNot = [new ExistsQuery() { Field = dateExistsFilter.FieldName }]
                    }
                ]
            });
        }

        if(filter is ServiceTypeFilter IHasTermValueOrDoesNotExistsFilter)
        {
            mustQueries.Add(new BoolQuery()
            {
                Should =
                [
                    new TermQuery(((BaseFilter)filter).FieldName) { Value = ((IHasTermValueOrDoesNotExistsFilter)filter).Value },
                    new BoolQuery()
                    {
                        MustNot = [new ExistsQuery() { Field = ((BaseFilter)filter).FieldName }]
                    }
                ]
            });
        }
    }

    foreach (var filter in searchQuery.Filters.OfType<IMustExistsFilter>())
    {
        mustQueries.Add(new ExistsQuery() { Field = ((BaseFilter)filter).FieldName });
    }

    return mustQueries.Count != 0 ? mustQueries: null!;

    Query CreateDateComparisonFilter(DateExistsFilter dateExistsFilter) => dateExistsFilter.Comparison switch
    {
        DateExistsFilter.ComparisonType.Gt => new DateRangeQuery(dateExistsFilter.FieldName) { Gt = _timeProvider.GetUtcNow().DateTime },
        DateExistsFilter.ComparisonType.Lt => new DateRangeQuery(dateExistsFilter.FieldName) { Lt = _timeProvider.GetUtcNow().DateTime },
        DateExistsFilter.ComparisonType.Gte => new DateRangeQuery(dateExistsFilter.FieldName) { Gte = _timeProvider.GetUtcNow().DateTime },
        DateExistsFilter.ComparisonType.Lte => new DateRangeQuery(dateExistsFilter.FieldName) { Lte = _timeProvider.GetUtcNow().DateTime },
        _ => throw new NotImplementedException()
    };
}

[flobernd]

Thanks @jyrijh, this actually helped me to spot the bug in the generator. I'll fix this in the next patch release.