'Nest' does not have a strong name

[llampret]

Hey, would it be possible to sign Nest to have a strong name ?

Thank you

[cristianmad]

Any reason they are not signed?

We need to reference them from signed assemblies which is forcing us to sign them with our key. While this works, I think that they should be signed with your key. If someone updates the code then they can re-sign with their own key (if desired).

Thanks

[Mpdreamz]

Hey @cristianmad

Strongnaming introduces the need for assembly redirection if you include two libraries that in turn depend on different versions of NEST.

JSON.NET solved this by never updating the assembly version only on major version changes. I'm quite on the fence to this approach since it breaks the most sane way to check what version you are actually using.

I'm thinking of publishing a Nest.Signed separate nuget package which to me is the ideal situation as people themselves can choose how they want to reference Nest instead of me forcing it.

Still weighing the pro's and cons to this approach though, thoughts very much appreciated on this :)

[cristianmad]

Hi @Mpdreamz

Thank you for your reply. I do understand the reasoning behind your decision. It seems that JSON.NET is using the same approach .NET Framework does. Imagine the need to rebuild or define redirections each time a .NET Framework fix is released :)

Some component providers are doing exactly what you suggested. They are releasing 2 sets of assemblies, both signed and unsigned and then the customer decides which one to use.

[maximpashuk]

I have the same problem - I need to use NEST from assembly that strongly-typed.
I think separate nuget package for signed version of NEST is a best solution.

Are you plannig to publish Nest.Signed package in near future?

[maximpashuk]

Just for now I used ILMerge to sign NEST by my key

packages\ilmerge.2.13.0307\ilmerge.exe Nest.dll /keyfile:PublicKey.snk /out:out\Nest.dll

This works fine, but official dll with strong name is expected.

[llampret]

I agree with @cristianmad and @maximpashuk, 2nd nuget package "Nest.Signed" would be great.

[Mpdreamz]

Ok guys I updated my build scripts so that they create signed versions of the dlls and separate nuget packages for them.

I'll probably do a beta release soon, is anyone interested in beta testing them ?

Thanks in advance!

[maximpashuk]

I am interested in beta testing of signed versions for Nest and Nest.Thrift packages.