Skip to content

Consider deprecating UnexpectedElasticsearchClientException #1958

Closed
@gmarz

Description

@gmarz

Currently, all uhandled exceptions bubble up to Transport and are wrapped in an UnexpectedElasticsearchClientException before being re-thrown.

It feels like a borderline anti-pattern, and I'm on the fence as to whether or not this is really necessary. It forces us to create special exceptions (for instance, ResolveException) that can occur late in the pipeline, which need to be caught and re-thrown when all we want to do is simply allow an ArgumentException to bubble out. Why not just let "unexpected" exceptions to bubble out? It will be clear enough from the exception and stack trace what the issue is.

On the other hand, we'll lose things like the audit trail and response, but how often are they useful for these types of exceptions? They're more relevant for troubleshooting what went wrong in the request pipeline (PipelineException). Is this additional information worth the overhead?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions