RegisterPercolatorRequest throws exception when Object is passed in the Metadata

[gmoskovicz]

Test case 1: NEST 1.7

Success and creates the precolator:

    class Program
    {
        private static readonly ILog _log = LogManager.GetLogger(typeof(Program));

        static void Main(string[] args)
        {
            ElasticClient client = new ElasticClient(new ConnectionSettings(new Uri("http://172.19.131.118:9200"), "index"));
            var session = new Session();

            var response = client.RegisterPercolator(new RegisterPercolatorRequest("myindex", Guid.NewGuid().ToString())
            {
                Query = new MatchAllQuery(),
                MetaData = new Dictionary<string, object> 
                { 
                    { "Name" , "1" }, 
                    {"Data", session } // <<< FAIL ON THIS WHEN AN OBJECT IS PASSED 
                }
            });

            var responseRaw = response;
            Console.WriteLine(responseRaw.ConnectionStatus.ResponseRaw.ToString());
        }
    }

    internal class Session
    {
        public object Performers { get; set; }
        public string Composers { get; set; }
    }

Test case 2: NEST 2.0

Fails to serialize class Session

    class Program
    {
        private static readonly ILog _log = LogManager.GetLogger(typeof(Program));

        static void Main(string[] args)
        {
            ElasticClient client = new ElasticClient(new ConnectionSettings(new Uri("http://172.19.131.118:9200")));
            var session = new Session();

            var response = client.RegisterPercolator(new RegisterPercolatorRequest("myindex", Guid.NewGuid().ToString())
            {
                Query = new MatchAllQuery(),
                Metadata = new Dictionary<string, object> 
                { 
                    { "Name" , "1" }, 
                    {"Data", session } // <<< FAIL ON THIS WHEN AN OBJECT IS PASSED 
                }
            });

            var responseRaw = response;
            Console.WriteLine(responseRaw.CallDetails);
        }
    }

    internal class Session
    {
        public object Performers { get; set; }
        public string Composers { get; set; }
    }

An unhandled exception of type 'Elasticsearch.Net.UnexpectedElasticsearchClientException' occurred in Elasticsearch.Net.dll

Additional information: Unsupported type: ConsoleApplication1.Session. Use the JsonSerializer class to get the object's JSON representation. Path ''.

Looks like https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/Search/Percolator/RegisterPercolator/RegisterPercolatorJsonConverter.cs#L52 is failing

Looks like the class Session should implement JsonConverter with the ReadJson and WriteJson in order to do this. However it will be nice to automatically conver this class to the Json Representation as we did in 1.x.

[EricKeij]

Is there some workaround for this?

AFAIK even if Session implements JsonConverter this will give us the same exception. Because RegisterPercolatorJsonConverter will still call WriteValue which does not accept an object (or at least not an object which can be written as a single JSON token).