Revert ResolveException until #1958 is resolved

Author: gmarz

src/Elasticsearch.Net/Elasticsearch.Net.csproj

@@ -83,7 +83,6 @@
     <Compile Include="ElasticLowLevelClient.cs" />
     <Compile Include="ElasticLowLevelClient.Generated.cs" />
     <Compile Include="Exceptions\ElasticsearchClientException.cs" />
-    <Compile Include="Exceptions\ResolveException.cs" />
     <Compile Include="Exceptions\UnexpectedElasticsearchClientException.cs" />
     <Compile Include="Extensions\ExceptionExtensions.cs" />
     <Compile Include="Extensions\Extensions.cs" />

src/Elasticsearch.Net/Exceptions/ResolveException.cs

@@ -83,10 +83,6 @@ public ElasticsearchResponse<TReturn> Request<TReturn>(HttpMethod method, string
 						pipeline.MarkDead(node);
 						seenExceptions.Add(pipelineException);
 					}
-					catch (ResolveException)
-					{
-						throw;
-					}
 					catch (Exception killerException)
 					{
 						throw new UnexpectedElasticsearchClientException(killerException, seenExceptions)
@@ -147,10 +143,6 @@ public async Task<ElasticsearchResponse<TReturn>> RequestAsync<TReturn>(HttpMeth
 						pipeline.MarkDead(node);
 						seenExceptions.Add(pipelineException);
 					}
-					catch (ResolveException)
-					{
-						throw;
-					}
 					catch (Exception killerException)
 					{
 						throw new UnexpectedElasticsearchClientException(killerException, seenExceptions)

src/Elasticsearch.Net/Transport/Transport.cs

@@ -71,7 +71,7 @@ private string Resolve(Expression expression, MemberInfo member, bool toLastToke
 					: null;
 
 			if (name == null)
-				throw new ResolveException("Name resolved to null for the given Expression or MemberInfo.");
+				throw new ArgumentException("Name resolved to null for the given Expression or MemberInfo.");
 
 			return name;
 		}

src/Nest/CommonAbstractions/Infer/Field/FieldResolver.cs

@@ -18,7 +18,6 @@ public string Resolve(IndexName i)
 		{
 			if (i == null || string.IsNullOrEmpty(i.Name))
 				return this.Resolve(i.Type);
-			ValidateIndexName(i.Name);
 			return i.Name;
 		}
 
@@ -32,21 +31,7 @@ public string Resolve(Type type)
 				if (defaultIndices.TryGetValue(type, out value) && !string.IsNullOrEmpty(value))
 					indexName = value;
 			}
-			ValidateIndexName(indexName, type);
 			return indexName;
 		}
-
-		private void ValidateIndexName(string indexName, Type type = null)
-		{
-			if (string.IsNullOrWhiteSpace(indexName))
-				throw new ResolveException(
-					"Index name is null for the given type and no default index is set. "
-					+ "Map an index name using ConnectionSettings.MapDefaultTypeIndices() "
-					+ "or set a default index using ConnectionSettings.DefaultIndex()."
-				);
-
-			if (indexName.HasAny(c => char.IsUpper(c)))
-				throw new ResolveException($"Index names cannot contain uppercase characters: {indexName}.");
-		}
 	}
 }

src/Nest/CommonAbstractions/Infer/IndexName/IndexNameResolver.cs

@@ -48,41 +48,5 @@ public void ExplicitMappingTakesPrecedence()
 			var index = resolver.Resolve<Project>();
 			index.Should().Be("projects");
 		}
-
-		[U]
-		public void UppercaseCharacterThrowsResolveException()
-		{
-			var settings = new ConnectionSettings()
-				.DefaultIndex("Default")
-				.MapDefaultTypeIndices(m => m
-					.Add(typeof(Project), "myProjects")
-				);
-
-			var resolver = new IndexNameResolver(settings);
-
-			var e = Assert.Throws<ResolveException>(() => resolver.Resolve<Project>());
-			e.Message.Should().Be($"Index names cannot contain uppercase characters: myProjects.");
-			e = Assert.Throws<ResolveException>(() => resolver.Resolve<Tag>());
-			e.Message.Should().Be($"Index names cannot contain uppercase characters: Default.");
-			e = Assert.Throws<ResolveException>(() => resolver.Resolve("Foo"));
-			e.Message.Should().Be($"Index names cannot contain uppercase characters: Foo.");
-		}
-
-		[U]
-		public void NoIndexThrowsResolveException()
-		{
-			var settings = new ConnectionSettings();
-			var resolver = new IndexNameResolver(settings);
-			var e = Assert.Throws<ResolveException>(() => resolver.Resolve<Project>());
-			e.Message.Should().Contain("Index name is null");
-		}
-
-		[U]
-		public void ResolveExceptionBubblesOut()
-		{
-			var client = TestClient.GetInMemoryClient(s => new ConnectionSettings());
-			var e = Assert.Throws<ResolveException>(() => client.Search<Project>());
-
-		}
 	}
 }