Skip to content

Docs: Handle more funny cases from ES api spec #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 29, 2019

Handles a few "special" doc urls from ES's api spec files. These are
only a problem in 6.x but we'd like to keep the generateDocs script the
same across all branches for easier backporting.

Handles a few "special" doc urls from ES's api spec files. These are
only a problem in 6.x but we'd like to keep the generateDocs script the
same across all branches for easier backporting.
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Mar 29, 2019

Thanks for reviewing @delvedor! Sorry this is such a mess....

@delvedor
Copy link
Member

Thanks for reviewing @delvedor! Sorry this is such a mess....

No worries, thank you for all the help!

@delvedor delvedor merged commit 0073756 into master Mar 29, 2019
@delvedor delvedor deleted the docs_fix_2 branch March 29, 2019 14:44
delvedor pushed a commit that referenced this pull request Mar 29, 2019
Handles a few "special" doc urls from ES's api spec files. These are
only a problem in 6.x but we'd like to keep the generateDocs script the
same across all branches for easier backporting.
delvedor pushed a commit that referenced this pull request Mar 29, 2019
Handles a few "special" doc urls from ES's api spec files. These are
only a problem in 6.x but we'd like to keep the generateDocs script the
same across all branches for easier backporting.
delvedor pushed a commit that referenced this pull request Mar 29, 2019
Handles a few "special" doc urls from ES's api spec files. These are
only a problem in 6.x but we'd like to keep the generateDocs script the
same across all branches for easier backporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants