Skip to content

Add test to verify default node filter function #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Apr 16, 2025

Turns out elastic/elastic-transport-js#231 doesn't require any actual fix in the client! Adding a test and updating docs anyway.

@JoshMock
Copy link
Member Author

Tests will fail until the next transport patch release goes out.

@JoshMock JoshMock merged commit 98b3802 into main Apr 16, 2025
22 of 23 checks passed
@JoshMock JoshMock deleted the node-roles-fix branch April 16, 2025 18:28
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2756-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98b38028aa7b93cb14aa52e67c8e0bf2bbaf45af
# Push it to GitHub
git push --set-upstream origin backport-2756-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2756-to-8.x.

JoshMock added a commit that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant