Skip to content

[DOCS]Removes link pointing to EIS reference docs #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

szabosteve
Copy link
Contributor

Overview

EIS won't be released in 8.18/9.0. The docs referencing EIS need to be pulled out from the generated docs.
This PR pullso out EIS docs from ES: elastic/elasticsearch#126381
The CI on that PR fails as one of the pages in elasticsearch-js links to the content I want to remove. This PR deletes the link to unblock the PR in the ES repo.

@szabosteve szabosteve requested a review from JoshMock April 7, 2025 10:29
@JoshMock
Copy link
Member

JoshMock commented Apr 7, 2025

Merging as-is, but also updated the code generator to ensure the link doesn't come back.

@JoshMock JoshMock merged commit 6042bcd into 8.x Apr 7, 2025
8 checks passed
@JoshMock JoshMock deleted the szabosteve/8.x-pull-out-eis branch April 7, 2025 16:02
Copy link
Contributor

github-actions bot commented Apr 7, 2025

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-2708-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6042bcd20c4b69b0f92801e3389b34780be844b1
# Push it to GitHub
git push --set-upstream origin backport-2708-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-2708-to-8.16.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-2708-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6042bcd20c4b69b0f92801e3389b34780be844b1
# Push it to GitHub
git push --set-upstream origin backport-2708-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-2708-to-8.17.

github-actions bot pushed a commit that referenced this pull request Apr 7, 2025
JoshMock pushed a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit 6042bcd)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Copy link
Contributor

github-actions bot commented Apr 7, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2708-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6042bcd20c4b69b0f92801e3389b34780be844b1
# Push it to GitHub
git push --set-upstream origin backport-2708-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2708-to-8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants