-
Notifications
You must be signed in to change notification settings - Fork 729
[DOCS] Creates custom landing page for the JS client book (#1831 #1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@elasticmachine test this please |
This is an empty link. 🙂 Can you update so I can take a look at the preview? |
@JoshMock It's empty because the docs-ci didn't generate a preview for the landing page so I haven't been able to add a URL to the link. I'm currently working with docs-infra to determine why the preview is unavailable. When I have something to show, I'll ask for a review if that's okay. |
@JoshMock Could you please review my PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! What an improvement.
The one failing job on the PR appears to be the YAML REST tests, which I assume is unrelated to this change entirely. Pinging @sethmlarson just to verify that since I'm still getting my bearings. 😎
++ YAML REST test failures are unrelated |
@JoshMock @sethmlarson Thanks for the review! Could either of you please merge this PR? I cannot merge it myself because of the failing CI job. Thank you very much in advance! |
* [DOCS] Creates custom landing page for the JS client book. * [DOCS] Fine-tunes text. * [DOCS] Updates hero image. * [DOCS] Changes page file name. * [DOCS] Adds one-liner to hero. * [DOCS] Reduces padding. * [DOCS] Changes section title. * [DOCS] Fine-tunes text.
Overview
This PR adds a new landing page to the JS client book so it will be more in line with the main docs landing page, the ES guide landing page, and the Kibana guide landing page.
The content can be easily modified based on feedback.