Skip to content

[DOCS] Creates custom landing page for the JS client book (#1831 #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Mar 22, 2023

Overview

This PR adds a new landing page to the JS client book so it will be more in line with the main docs landing page, the ES guide landing page, and the Kibana guide landing page.

The content can be easily modified based on feedback.

@szabosteve
Copy link
Contributor Author

@elasticmachine test this please

@szabosteve szabosteve marked this pull request as ready for review March 23, 2023 09:22
@szabosteve szabosteve closed this Mar 23, 2023
@szabosteve szabosteve reopened this Mar 23, 2023
@JoshMock
Copy link
Member

New JS docs landing page proposed in this PR

This is an empty link. 🙂 Can you update so I can take a look at the preview?

@szabosteve
Copy link
Contributor Author

@JoshMock It's empty because the docs-ci didn't generate a preview for the landing page so I haven't been able to add a URL to the link. I'm currently working with docs-infra to determine why the preview is unavailable. When I have something to show, I'll ask for a review if that's okay.

@szabosteve szabosteve requested a review from JoshMock March 23, 2023 16:51
@szabosteve
Copy link
Contributor Author

szabosteve commented Mar 24, 2023

@JoshMock Could you please review my PR?

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! What an improvement.

The one failing job on the PR appears to be the YAML REST tests, which I assume is unrelated to this change entirely. Pinging @sethmlarson just to verify that since I'm still getting my bearings. 😎

@sethmlarson
Copy link
Contributor

++ YAML REST test failures are unrelated :shipit:

@szabosteve
Copy link
Contributor Author

@JoshMock @sethmlarson Thanks for the review! Could either of you please merge this PR? I cannot merge it myself because of the failing CI job. Thank you very much in advance!

@JoshMock JoshMock enabled auto-merge (squash) March 28, 2023 16:54
@JoshMock JoshMock disabled auto-merge March 28, 2023 16:54
@JoshMock JoshMock changed the title [DOCS] Creates custom landing page for the JS client book [DOCS] Creates custom landing page for the JS client book (#1831 Mar 29, 2023
@JoshMock JoshMock merged commit ce37b0f into main Mar 29, 2023
@JoshMock JoshMock deleted the szabosteve/custom-landing-page branch March 29, 2023 17:00
github-actions bot pushed a commit that referenced this pull request Mar 29, 2023
* [DOCS] Creates custom landing page for the JS client book.

* [DOCS] Fine-tunes text.

* [DOCS] Updates hero image.

* [DOCS] Changes page file name.

* [DOCS] Adds one-liner to hero.

* [DOCS] Reduces padding.

* [DOCS] Changes section title.

* [DOCS] Fine-tunes text.
szabosteve added a commit that referenced this pull request Mar 30, 2023
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants