Support include_names_queries_score #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
requested changes
Apr 2, 2025
| // Array case, deserializing it into a map with null values | ||
| if (event == Event.START_ARRAY) { | ||
| while ((event = parser.next()) != Event.END_ARRAY) { | ||
| JsonpUtils.ensureAccepts(itemDeserializer, parser, event); |
There was a problem hiding this comment.
This should be JsonpUtils.expectEvent(Event.VALUE_STRING, event): itemDeserializer is for map values, and in the case of an array we only have string values that would be keys in the map.
swallez
approved these changes
Apr 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
* prep * regen on generator changes + unit test * restore include_names_queries_score * checkstyle * array can only expect string in this case
l-trotta
added a commit
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated output + unit test handling
matched_queriesas an actual array | map union.Generator reference: https://github.com/elastic/elastic-client-generator-java/pull/58
Fixes #634