Skip to content

Adding telemetry and user agent headers #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Adding telemetry and user agent headers #35

merged 5 commits into from
Oct 21, 2021

Conversation

technige
Copy link
Contributor

@technige technige commented Oct 14, 2021

Reopening #32 on the telemetry branch instead.

This PR is to add the following headers to all requests:

  • User-Agent
  • X-Elastic-Client-Meta

@technige technige force-pushed the telemetry branch 3 times, most recently from 927232f to 647f39a Compare October 21, 2021 10:11
Also adds more control over headers, including User-Agent,
X-Elastic-Client-Meta and custom headers.
@technige technige marked this pull request as ready for review October 21, 2021 10:17
@technige technige requested a review from swallez October 21, 2021 10:18
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll take it from there to add the code-generated bits to configure request options in API clients.

@technige technige merged commit 93565ea into main Oct 21, 2021
@technige technige deleted the telemetry branch October 21, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants