Skip to content

Fully targeting java 8 #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Fully targeting java 8 #1006

merged 1 commit into from
May 2, 2025

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented May 2, 2025

Fixes #995

@l-trotta l-trotta merged commit 3493296 into 8.18 May 2, 2025
9 checks passed
@l-trotta l-trotta deleted the target-java-8 branch May 2, 2025 12:45
github-actions bot pushed a commit that referenced this pull request May 2, 2025
Copy link

github-actions bot commented May 2, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-1006-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 34932963d36185c756b0e94c29828ef06160828f
# Push it to GitHub
git push --set-upstream origin backport-1006-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-1006-to-8.x.

l-trotta added a commit that referenced this pull request May 2, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
@l-trotta
Copy link
Contributor Author

l-trotta commented May 2, 2025

manually backporting to 8.x 8.19 (should've started from 8.x 8.19 actually)

l-trotta added a commit that referenced this pull request May 2, 2025
l-trotta added a commit that referenced this pull request May 27, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant