Skip to content

Set Spark 3.x default to Scala 2.13 #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 31, 2025
Merged

Conversation

samxbr
Copy link
Contributor

@samxbr samxbr commented Jan 21, 2025

This change upgrades the default Scala version from 2.12 to 2.13 for Spark 3.x artifacts.

Comment on lines 75 to 77
compileOnly("com.fasterxml.jackson.module:jackson-module-scala_2.12:2.6.7.1")
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.6.7")
compileOnly("org.json4s:json4s-jackson_2.12:3.2.11")
compileOnly("com.fasterxml.jackson.module:jackson-module-scala_2.13:2.9.10")
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.9.10")
compileOnly("org.json4s:json4s-jackson_2.13:3.6.7")
Copy link
Contributor Author

@samxbr samxbr Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update jackson dependencies to Scala 2.13 versions

Comment on lines +81 to +82
// artifact name: https://spark.apache.org/downloads.html
return "spark-$version-bin-hadoop${hadoopVersionCompatibility()}-scala2.13"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masseyke for finding this.

@samxbr samxbr marked this pull request as ready for review January 29, 2025 12:36
@samxbr samxbr requested review from jbaiera and masseyke January 29, 2025 12:36
@masseyke
Copy link
Member

Just so I understand -- the impact here is that now our uber jar (which I would advise people not not use anyway) will use scala 2.13, and more of our testing (specifically maybe just the kerberos testing?) will use scala 2.13. Right? Or is there another impact that I'm missing?

@samxbr
Copy link
Contributor Author

samxbr commented Jan 30, 2025

Just so I understand -- the impact here is that now our uber jar (which I would advise people not not use anyway) will use scala 2.13, and more of our testing (specifically maybe just the kerberos testing?) will use scala 2.13. Right? Or is there another impact that I'm missing?

@masseyke Your understanding is correct, I think this is really a good-to-have follow up change from comments in #2316. @jbaiera please correct me if I am wrong.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samxbr samxbr added v9.1.0 and removed v9.0.0 labels Jan 31, 2025
@samxbr samxbr merged commit 987ab40 into elastic:main Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants