-
Notifications
You must be signed in to change notification settings - Fork 992
Set Spark 3.x default to Scala 2.13 #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qa/kerberos/build.gradle
Outdated
compileOnly("com.fasterxml.jackson.module:jackson-module-scala_2.12:2.6.7.1") | ||
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.6.7") | ||
compileOnly("org.json4s:json4s-jackson_2.12:3.2.11") | ||
compileOnly("com.fasterxml.jackson.module:jackson-module-scala_2.13:2.9.10") | ||
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.9.10") | ||
compileOnly("org.json4s:json4s-jackson_2.13:3.6.7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update jackson dependencies to Scala 2.13 versions
// artifact name: https://spark.apache.org/downloads.html | ||
return "spark-$version-bin-hadoop${hadoopVersionCompatibility()}-scala2.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masseyke for finding this.
Just so I understand -- the impact here is that now our uber jar (which I would advise people not not use anyway) will use scala 2.13, and more of our testing (specifically maybe just the kerberos testing?) will use scala 2.13. Right? Or is there another impact that I'm missing? |
@masseyke Your understanding is correct, I think this is really a good-to-have follow up change from comments in #2316. @jbaiera please correct me if I am wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change upgrades the default Scala version from 2.12 to 2.13 for Spark 3.x artifacts.