Fix deprecation warnings #1663
Merged
Fix deprecation warnings #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for
elasticsearch-py8.x support, I've looked at deprecation warnings emitted when running the test suite and fixed them, following the official recommendation.The way filterwarnings work is that by default we raise an exception instead of a warning (this is what
errordoes), but then we also add special cases, currently two of them.I also removed the pins on
pytest-mockandcoverage: they were only needed to support Python 2.7 and produced deprecation warnings themselves. The benefit is that the test suite will break if a new deprecation warning is introduced. If this causes too much noise, we can always adjust our strategy later.