-
Notifications
You must be signed in to change notification settings - Fork 99
Remove the Serverless label from ILM docs #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #1196 Removes the serverless applies_to tag from the ILM section of the Data lifecycle docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One small comment, not really related with the scope of this PR.
In the Data Tiers
page of Data lifecycle we have the "Serverless" tag, and I'm not sure if we should remove it from there too. Just for your consideration and analysis.
Thanks for the review, @eedugon! To address your comment, I think the Data tiers page applies to both (so both Serverless and Elastic Stack labels apply) judging by this snippet:
Just to doublecheck, @shainaraskas or @kilfoyle , could either of you confirm, please? Many thanks, |
@yetanothertw @eedugon is correct that data tiers are generally a stack concept only. data tiers specifically are meant to allow you to configure different hardware for different categories of data (very simplified definition). as a rule, anything that talks about hardware/sizing centric concepts (nodes, shards, hot spotting all fall into this category) does not apply to serverless. this is because the value prop of serverless is that you don't have to think about hardware or sizing at all. in stack, technically data stream lifecycle might interact with tiers just by virtue of running on hardware that is set up to use tiers, but it doesn't do a great job of interacting with tiers, especially granular ones. the callout on the tiers page might be a little misleading. but data stream lifecycle doesn't rely on manual configuration of tiers, making DSL serverless-compatible. this page is probably our most accurate in terms of "what applies to serverless" - when in doubt, you can check there as well. it touches on tiers. ALL THAT BEING SAID: will take a look at the rest of the pr shortly - sorry for wall of text :) |
similarly, I don't think serverless supports curator. not sure about that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I thought I submitted a review but I didn't - these tag removals look good. see my other comments re: data tiers and curator
Adding an admonition to specify that data tiers is automated in Serverless.
Fixes #1196 Removes the serverless applies_to tag from the ILM section of the Data lifecycle docs.
Adding an admonition to specify that data tiers is automated in Serverless.
The admonition change hasn't saved properly in the prev commit so adding it now.
Thank you for detailed response @shainaraskas -- I've removed the labels from curator and data tiers. I want to add the admonition you suggested to make it clear that Serverless manages data tier concepts for you. Does this look right to you: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1531/manage-data/lifecycle/data-tiers I wasn't sure if I should keep the link to project settings, like in the admonition you referenced, as it doesn't seem relevant. |
Removed the admonition and opened issue #1200 to address this concern separately.
Opened issue #1547 to address the admonition suggestion separately. Thanks all. |
Fixes #1196
Removes the serverless applies_to tag from the ILM section of the Data lifecycle docs.
Preview available here