Sync with esp8266/Arduino master #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TZ: help newlib parser Timezones coded with numeric abbreviations <±nn>±nn<±nn>[±nn][,...] are incorrectly parsed by newlib's TZ parser. Replacing <±nn> occurences by UNK allows newlib's TZ parser to nicely interpret all timezones. Detailed explanation in earlephilhower/newlib-xtensa#12
Undoes the change in #7699 and fixed #7690 root cause. Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and would parse the offset using the <name>. Fix newlib tzset parser with earlephilhower/newlib-xtensa#14 earlephilhower/newlib-xtensa#15 and undo the UNK changes used as an expedient workaround.
* The default timings were chosen vastly outside specification. On COTS servos, this causes much confusion for the user, because a wide range of angle starting from 0 degress, and a just a large range of angle leading up to 180 degrees, is dead - in fact, the servo doesn't move at all, from any position. Not investigated further for obvious reasons, as this may have also destroyed servos that ran hot trying to abide by the PWM signal but could not mechanically! * Change timing limits to safe values. With previous default timings and safety limits, popular servos could force against internal physical endstops, which could overload and destroy them. * Review action: revert changes to hard boundary for min/max duty cycle timings. Internal review, fix/drop legacy comments. * A Servo on each available ESP8266 GPIO (D0-D8), no observed interference. * Remove possible jerk due to force-cancelling duty cycle. * Overload attach: can specify initial angle for servo, too. * Stricter checks for configured, and default, bounded timings. * Missed the min/max in a comment. * Default microsecond lower bound of 1000 causes confusing behavior - 200 is minimum enforced elsewhere, so use it here too as nearest multiple of 100 from 180. * Comment rationale for changed defaults of min/max pulse widths. Comment rationale for changed defaults of min/max pulse widths.
sntp_get_real_time takes a `time_t` in the core, but in the header it was listed as `long`. Make them both match by changing the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.