Implement IConnectionEndPointFeature in Kestrel's TransportConnection #62162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
IConnectionEndPointFeature
in Kestrel'sTransportConnection
class to address the issue where this feature was only available in test scenarios viaDefaultConnectionContext
.Background
IConnectionEndPointFeature
was added as part of bedrock in #10321 but was only implemented inDefaultConnectionContext
, which is primarily used by test projects. This meant that production Kestrel connections couldn't access endpoint information through the standard feature interface.Changes
The implementation adds
IConnectionEndPointFeature
support toTransportConnection
by:TransportConnectionFeatureCollection.cs
to includeIConnectionEndPointFeature
in bothallFeatures
andimplementedFeatures
arraysTransportConnection.Generated.cs
with the new feature supportTransportConnection.FeatureCollection.cs
that delegate to the existingLocalEndPoint
andRemoteEndPoint
propertiesUsage
After this change, applications can access connection endpoints through the feature interface:
This maintains full compatibility with existing code that uses the direct properties while providing the standard feature interface for consistency with other ASP.NET Core components.
Impact
Fixes #43786.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.