Fix OpenApiJsonSchema array parsing (#62051) #62118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
Servicing-consider
captainsafia
approved these changes
May 27, 2025
BrennanConroy
added
Servicing-approved
|
Hi @@BrennanConroy. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62051
Fix OpenApiJsonSchema array parsing
Description
When using the
MapOpenApi()endpoint with a custom json converter that outputs an array with a default value, the app would crash with a stack overflow. The issue was that we never advanced theUtf8JsonReaderwhen calling a recursive function. So we'd end up looking at the same json value over and over until stack overflowing.Fixes #62023
Customer Impact
App can crash when accessing the OpenApi endpoint.
Regression?
Risk
Obvious bug once pointed out. Fixed missing test coverage.
Verification
Packaging changes reviewed?