Add WebAssemblyHotReloadCapabilities to Microsoft.AspNetCore.Components.WebAssembly.props #61946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested changes
May 14, 2025
…ts.WebAssembly.props
javiercn
reviewed
May 16, 2025
| @@ -2,6 +2,7 @@ | |||
| <PropertyGroup> | |||
| <BlazorWebAssemblyJSPath>$(MSBuildThisFileDirectory)blazor.webassembly.js</BlazorWebAssemblyJSPath> | |||
| <BlazorRoutingEnableRegexConstraint Condition="'$(BlazorRoutingEnableRegexConstraint)' == ''">false</BlazorRoutingEnableRegexConstraint> | |||
| <WebAssemblyHotReloadCapabilities>Baseline;AddMethodToExistingType;AddStaticFieldToExistingType;NewTypeDefinition;ChangeCustomAttributes;AddInstanceFieldToExistingType;GenericAddMethodToExistingType;GenericUpdateMethod;UpdateParameters;GenericAddFieldToExistingType</WebAssemblyHotReloadCapabilities> | |||
There was a problem hiding this comment.
Should this go into the \build\*.props file for the Hot Reload agent package long term?
/cc: @maraf
There was a problem hiding this comment.
I don't think so. This is specific to WASM. In other cases the agent retrieves the information from the runtime. The problem with WASM is that the runtime (and the agent) might not be loaded yet into the browser at the point we need the information.
javiercn
approved these changes
May 16, 2025
@wtgodbe Done |
wtgodbe
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-watch expects capabilities to be specified by the project for projects targeting net10+