Skip to content

[release/3.1] Minor cleanup #33419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2021
Merged

[release/3.1] Minor cleanup #33419

merged 4 commits into from
Jun 10, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jun 9, 2021 •
edited
Loading

  • !nit! Do not use pwsh aliases
  • !nit! Remove minor infra differences from 'main'
  • Clean up warnings about EOL TFMs
  • !nit! Remove dangling project reference

dougbu added 3 commits June 9, 2021 16:22
@dougbu
!nit! Do not use pwsh aliases
dd2729f 
- take VS Code suggestions
@dougbu
!nit! Remove minor infra differences from 'main'
e369cb3 
- mostly comment and whitespace cleanup
- work toward making comparisons more meaningful
@dougbu
Clean up warnings about EOL TFMs
0554b5e 
- move to non-EOL TFM in Ignitor; not a shipping project
- suppress NETSDK1138 warnings in KeyDerivation project
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 9, 2021
@dougbu dougbu requested review from pranavkm, HaoK and a team June 9, 2021 23:44
@dougbu dougbu requested a review from SteveSandersonMS as a code owner June 9, 2021 23:44
@dougbu
Copy link
Contributor Author

dougbu commented Jun 9, 2021

@Pilchie mostly nits and the closest thing to a product change is the TFM change in the non-shipping Ignitor project. tell-mode❔

@dougbu
!nit! Remove dangling project reference
93d646f 
- 6c16632 removed ProjectTemplates/ComponentsWebAssembly.ProjectTemplates/ folder
@dougbu dougbu enabled auto-merge (squash) June 10, 2021 00:00
@dougbu dougbu disabled auto-merge June 10, 2021 00:00
@Pilchie Pilchie added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 10, 2021
@Pilchie
Copy link
Member

Pilchie commented Jun 10, 2021

tell-mode works for me.

@dougbu dougbu merged commit b6c411f into release/3.1 Jun 10, 2021
@dougbu dougbu deleted the dougbu/cleanup/3.1 branch June 10, 2021 17:42
@dougbu dougbu added this to the 3.1.17 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@HaoK HaoK HaoK approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @Pilchie @pranavkm @HaoK