Make ProblemDetailsDefaults public

[Tornhoof]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

I am trying to create ProblemDetails, e.g.ValidationProblemDetails outside of a normal Http Request.
The rather nice default values, e.g.Type String, which is according to the RFC the correct way to identify it, are applied via

aspnetcore/src/Shared/ProblemDetails/ProblemDetailsDefaults.cs

Lines 110 to 115 in 900660b

	public static void Apply(ProblemDetails problemDetails, int? statusCode)
	{
	// We allow StatusCode to be specified either on ProblemDetails or on the ObjectResult and use it to configure the other.
	// This lets users write <c>return Conflict(new Problem("some description"))</c>
	// or <c>return Problem("some-problem", 422)</c> and have the response have consistent fields.
	if (problemDetails.Status is null)

Unfortunately the type is not public, but internal.

Describe the solution you'd like

It would be rather useful, as ProblemDetails is public, to make that one public too, so I don't need to copy the logic around.

Additional context

Alternatively a new method could be added to IProblemDetailsService to allow access to the defaults.

[campbellwray]

I too think that making this public, or some similar workaround would be helpful

[halter73]

@Tornhoof @campbellwray would either of you be interested in filling out an API proposal for this? You can file a new issue or just use the template in a new comment here. We could make the proposal just to make the internal type public. e.g.

// Microsoft.AspNetCore.Http.Extensions.dll (ProblemDetailsDefaults is currently in multiple assemblies, but they all depend on Http.Extensions)

namespace Microsoft.AspNetCore.Http;
 
+ public static class ProblemDetailsDefaults
+ {
+     public static void Apply(ProblemDetails problemDetails, int? statusCode);
+ }

I'm not sure Apply is a descriptive enough name though. Maybe we could just add a method directly to ProblemDetails.

// Microsoft.AspNetCore.Http.Abstractions.dll

namespace Microsoft.AspNetCore.Mvc;
 
public class ProblemDetails
{
+     public void ApplyStatusCodeDefaults(int? statusCode);
}

[Tornhoof]

Yeah, I will do so.

[Tornhoof]

I'll close this in favor of #47978