Skip to content

fix: re-render gitalk when router changed #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

spiritree
Copy link
Contributor

No description provided.

@timaschew
Copy link
Member

Hi @spiritree
thanks for you contribution.

Can you explain why it's required to render this plugin again?
Maybe other plugins are affected as well?
In that case the logic should be extracted into a common helper function or something like that.

@QingWei-Li any feedback?

@spiritree
Copy link
Contributor Author

spiritree commented Feb 25, 2019

@timaschew
The re-render logic is similiar with disqus plugin.

hook.doneEach(_ => {

There is no need to be extracted into a common helper function because it's a unique plugin.

@timaschew
Copy link
Member

Okay, but why is it required to render it again actually?

@spiritree
Copy link
Contributor Author

@timaschew
This plugin is a comment component based on Github issue.
So when router changed,you must re-render it to create unique issue.

@timaschew timaschew merged commit d5910bd into docsifyjs:master Mar 3, 2019
@qufei1993
Copy link

reference: https://www.nodejs.red/#/tools/docsify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants