Skip to content

fix: rendering cover width bug #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

fix: rendering cover width bug #1147

merged 1 commit into from
May 22, 2020

Conversation

HerbertHe
Copy link
Contributor

Summary

fix cover rendering bug, the width of cover has not filled the whole page

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

before

sometimes display not well but not always

after

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share the before screen shot ?

@HerbertHe
Copy link
Contributor Author

sorry, it happens sometimes but not always. when I refreshed, it would be normal

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to don't change things when it isn't reproducible stably.

@anikethsaha
Copy link
Member

I prefer to don't change things when it isn't reproducible stably.

agreed 💯

this might be a safe change. but still, @HerbertHe can you at least describe what you did to produce this

@HerbertHe
Copy link
Contributor Author

I prefer to don't change things when it isn't reproducible stably.

agreed 💯

this might be a safe change. but still, @HerbertHe can you at least describe what you did to produce this

Once, when I refresh the page but the cover page leaved behind a space area, so I check the style of the DOM node. I found that the class section.cover didn't include the style to control the width, and I added width: 100vw; to the class and then it displayed well. At most time, the content would fill all of the width, but I think that limiting the style seems better.

And I only add the width: 100vw; to limit the style of the cover width.

@anikethsaha anikethsaha merged commit bd9e24b into docsifyjs:develop May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants