Python 3.7: Install libuuid packages for native _uuid module #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On my machine, running benchmarks like these, I got ~20% speedup on both UUID1 generation and module import. So not a huge increase on already quite fast operations. |
tianon
reviewed
Aug 3, 2018
| @@ -12,6 +12,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| # Python 3.4 on Stretch+ needs to use an older version of "libssl-dev" (these lines both get removed for every other combination) | |||
| libssl-dev \ | |||
| tk-dev \ | |||
| uuid-dev \ | |||
There was a problem hiding this comment.
Hah, we finally found a popular -dev that isn't already part of buildpack-deps! 😄
If we can find more examples of it being used (Ruby gems, etc), I'd be +1 to adding it to buildpack-deps itself, but that's a separate discussion. 😇
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 3, 2018
- `drupal`: 8.6.0-beta2 - `mysql`: install more utilities (docker-library/mysql#465) - `python`: native `_uuid` (docker-library/python#326) - `redis`: 4.0.11, 5.0-rc4 - `rocket.chat`: Node.js 8.11 (RocketChat/Docker.Official.Image#43) - `wordpress`: 4.9.8
JayH5
added a commit
to praekeltfoundation/docker-alpine-python
that referenced
this pull request
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do:
I'm not sure how best to do the above?
The
util-linux-devpackage was actually already being installed (as a dependency oflibtirpc-dev) on Alpine so the native module was already being built and you can seelibuuidas one of the final Python runtime dependencies. This makes it explicit and gets Debian to build the module as well.