Fix arbitrary user support on oracle-linux based images #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
commented
Jul 12, 2022
Comment on lines
+105
to
+108
| # comment out a few problematic configuration values | ||
| find /etc/my.cnf /etc/mysql/ -name '*.cnf' -print0 \ | ||
| | xargs -0 grep -lZE '^(bind-address|log)' \ | ||
| | xargs -rt -0 sed -Ei 's/^(bind-address|log)/#&/'; \ |
There was a problem hiding this comment.
These lines are copied from the Debian Dockerfile even though we don't have a bind-address in the cnf file.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jul 12, 2022
Changes: - docker-library/mysql@bbcfaea: Merge pull request docker-library/mysql#889 from infosiftr/oracle-arbitrary-user-fix - docker-library/mysql@48f07e3: Fix arbitrary user support on oracle-linux based images
BaurzhanSakhariev
pushed a commit
to crate/official-images
that referenced
this pull request
Jul 18, 2022
Changes: - docker-library/mysql@bbcfaea: Merge pull request docker-library/mysql#889 from infosiftr/oracle-arbitrary-user-fix - docker-library/mysql@48f07e3: Fix arbitrary user support on oracle-linux based images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpm package has different opinions on the mode of
/var/run/mysqld, so we have to adjust permissions after install.When testing running as an arbitrary user, I also found that the
my.cnfin 5.7 has alog-error=/var/log/mysqld.logline which causes startup to break; so this should hopefully fix the missing log level in #880 since they have likely been going to a file 😞 🙈Fixes #887 resolves #880