Skip to content

load time zones into mysql #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2015
Merged

load time zones into mysql #80

merged 1 commit into from
Jul 7, 2015

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Jun 17, 2015

This enables time-zone support in mysql.

https://dev.mysql.com/doc/refman/5.7/en/time-zone-support.html

@yosifkit
Copy link
Member

LGTM

@yosifkit
Copy link
Member

ping @ltangvald

@ltangvald
Copy link
Collaborator

I'm not familiar with the bug in question, but shouldn't the workaround be for both 5.5 and 5.6 (bug was first reported for 5.0)?

Otherwise it looks good.

@phemmer
Copy link
Contributor Author

phemmer commented Jun 18, 2015

I'm not familiar with the bug in question, but shouldn't the workaround be for both 5.5 and 5.6 (bug was first reported for 5.0)?

I manually tested it on each of the versions, and 5.6 is the only one currently affected.

@ltangvald
Copy link
Collaborator

LGTM.
Guess the weirdness of the 5.5-image sometimes works in our favor :P

@tianon
Copy link
Member

tianon commented Jul 6, 2015

Can you update this to include the --protocol change from #84? If not, that's alright -- I can do it post merge instead if you'd prefer. 👍

@phemmer
Copy link
Contributor Author

phemmer commented Jul 7, 2015

@tianon Done.

@tianon
Copy link
Member

tianon commented Jul 7, 2015

Thanks! 👍

tianon added a commit that referenced this pull request Jul 7, 2015
@tianon tianon merged commit 7954d49 into docker-library:master Jul 7, 2015
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jul 8, 2015
- `golang`: 1.5beta1
- `mysql`: time zones (docker-library/mysql#80)
- `php`: 7.0.0beta1 (docker-library/php#113, docker-library/php#109)
- `postgres`: 9.5-alpha1 (docker-library/postgres#70), jessie (docker-library/postgres#71)
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `golang`: 1.5beta1
- `mysql`: time zones (docker-library/mysql#80)
- `php`: 7.0.0beta1 (docker-library/php#113, docker-library/php#109)
- `postgres`: 9.5-alpha1 (docker-library/postgres#70), jessie (docker-library/postgres#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants