move init-file processing into a function #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files found within /docker-entrypoint-initdb.d/* are processed using specific rules based on their filename. It was previously difficult to re-use this logic recursively, or to add logic for handling additional filetypes. By moving this logic into a shell function, we both enable inner shell scripts to easily re-use the same logic (for example, for including files from additional directories or sub-directories), and the possibility of overriding these processing rules entirely, for example to enable handling of additional filename patterns. There is a potential change of functionality compared to the previous version: the mysql command can no-longer be overridden by changing the mysql variable. Instead, the mysql command may be overridden only by overriding the process_init_file() function. There is a potentially loss of functionality in that included scripts can no-longer use "break" to escape the file loop. There is presently no work-around for this, as this is not expected to have been an intended feature.
|
though automated travis-ci has failed, (if I am reading the log correctly) these failures appear to be unrelated to the requested change. |
|
I am reopening after having caused a successful travis build based on my own repository ( no changes required - the issue appears to be a known instability in ha.pool.sks-keyservers.net , which is not involved in this pull request's changes ) |
|
I'm +1 on this, as compartmentalizing the different sections of the entrypoint script will in general make it easier to debug and make improvements |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
May 3, 2018
- `buildpack-deps`: add `netbase` - `gcc`: 8.1.0 - `ghost`: 1.22.5, 0.11.13 - `haproxy`: 1.7.11 - `mariadb`: 10.0.35 - `mongo`: 3.7.9 - `mysql`: docker-library/mysql#402 - `openjdk`: 11-ea-11, 8u171 - `php`: docker-library/php#627, docker-library/php#632 - `pypy`: docker-library/pypy#23 - `python`: add `netbase`, 3.7.0b4 - `rabbitmq`: 3.7.5-rc.1 - `rocket.chat`: 0.64.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have often found myself deriving the mysql image in order to make
it easier to process initialisation files in multiple paths, or to change
the rules used for processing such initialisation files. After having
made such extensions repeatedly, I have now attempted to clean
them up and make them generic enough for inclusion into the
upstream repository.
files found within /docker-entrypoint-initdb.d/* are processed using
specific rules based on their filename. It was previously difficult to
re-use this logic recursively, or to add logic for handling additional
filetypes.
By moving this logic into a shell function, we both enable inner shell
scripts to easily re-use the same logic (for example, for including
files from additional directories or sub-directories), and the
possibility of overriding these processing rules entirely, for example
to enable handling of additional filename patterns.
There is a potential change of functionality compared to the previous
version: the mysql command can no-longer be overridden by changing the
mysql variable. Instead, the mysql command may be overridden only by
overriding the process_init_file() function.
There is a potentially loss of functionality in that included scripts
can no-longer use "break" to escape the file loop. There is presently
no work-around for this, as this is not expected to have been an
intended feature.