Added security options #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added option for randomly generated root password * Added option to immediately expire root password Conflicts: 5.5/Dockerfile 5.5/docker-entrypoint.sh 5.6/Dockerfile 5.6/docker-entrypoint.sh 5.7/Dockerfile 5.7/docker-entrypoint.sh
| echo >&2 'error: database is uninitialized and password option is not specified ' | ||
| echo >&2 ' You need to specify one of MYSQL_ROOT_PASSWORD, MYSQL_ALLOW_EMPTY_PASSWORD and MYSQL_RANDOM_ROOT_PASSWORD' | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Whitespace here seems a little off -- is this tabs, or spaces?
There was a problem hiding this comment.
Yeah, looks like a mix. Will fix :)
|
Very nice additions IMO 👍 🤘 |
|
Should be fixed now :) |
|
LGTM |
1 similar comment
|
LGTM |
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 3, 2015
- `django` bump to 1.9 - `drupal` bump to 8.0.1 - `mongo` bump to 3.2.0-rc6 - `mysql` see docker-library/mysql#119 - `php` PHP 7.0 GA
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 3, 2015
- `django` bump to 1.9 - `drupal` bump to 8.0.1 - `mongo` bump to 3.2.0-rc6 - `mysql` see docker-library/mysql#119 - `php` PHP 7.0 GA
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 3, 2015
- `django` bump to 1.9 - `drupal` bump to 8.0.1 - `golang` bump 1.5.2 - `mongo` bump to 3.2.0-rc6 - `mysql` see docker-library/mysql#119 - `php` PHP 7.0 GA
pierreozoux
pushed a commit
to pierreozoux/official-images
that referenced
this pull request
Jan 7, 2016
- `django` bump to 1.9 - `drupal` bump to 8.0.1 - `golang` bump 1.5.2 - `mongo` bump to 3.2.0-rc6 - `mysql` see docker-library/mysql#119 - `php` PHP 7.0 GA
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `django` bump to 1.9 - `drupal` bump to 8.0.1 - `golang` bump 1.5.2 - `mongo` bump to 3.2.0-rc6 - `mysql` see docker-library/mysql#119 - `php` PHP 7.0 GA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* Added option to immediately expire root password
Installs pwgen package
MYSQL_RANDOM_ROOT_PASSWORD:
Uses pwgen to generate a password for the server's root user, and outputs it to the containers stdout
MYSQL_ONETIME_PASSWORD:
Sets root user as expired once init is complete, forcing a password change on first login (5.6+)