Skip to content

update: use the new README #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

noraj
Copy link

@noraj noraj commented Sep 28, 2021

@ldez
Copy link
Contributor

ldez commented Sep 28, 2021

Sorry, but we don't agree with these changes.

The file https://github.com/traefik/traefik-library-image/blob/master/README.md is not the "new" readme file.
(It's the opposite and I updated this file)

@ldez ldez mentioned this pull request Sep 28, 2021
@ldez
Copy link
Contributor

ldez commented Sep 28, 2021

Please close this PR: my PR #2043 do the expected changes.

@yosifkit yosifkit closed this Sep 28, 2021
@noraj
Copy link
Author

noraj commented Sep 28, 2021

Please close this PR: my PR #2043 do the expected changes.

🤔

  1. Why having Traefik v2 + Traefik v1 examples ?
  2. Please change traefik:v2.0 tags to traefik:v2.5 tags
  3. For the documentation rather than giving a 1.7 + 2.5 link, why not just giving https://doc.traefik.io/traefik/ without a version then people can choose the version they want
    image
    Else it we will need to update the documentation link at each minor version of each branch.
  4. Change the old https://community.containo.us to the new https://community.traefik.io/

@ldez
Copy link
Contributor

ldez commented Sep 28, 2021

  1. because we want to have both
  2. fixed in my PR
  3. fixed in my PR
  4. fixed in my PR

@noraj noraj deleted the patch-1 branch September 29, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker README
3 participants