Updating an existing Snippet results in invalid error message

[bartTC]

When you update an existing snippet, the admin will throw an error message "A Snippet with this name already exists."

Looks like the issue is the clean method, it literally checks if that snippet exists already. This makes sense for new snippets, but not for updating existing ones.

https://github.com/django-cms/djangocms-snippet/blob/master/src/djangocms_snippet/forms.py#L37-L46

Steps to reproduce:

• Go to Admin > Snippets > Snippet
• Add a new Snippet
• Add any name and HTML content
• Hit "Save and continue editing"
• Hit "Save and continue editing" again

[bartTC]

I fixed this on my side now by monkeypatching the clean method.

class BetterSnippetForm(SnippetForm):
    def clean(self) -> dict:
        return self.cleaned_data

I think it's better to rely on a unique=True property in the name/slug Model field rather than trying to fix it within the clean method. Though that might not be backwards compatible.

[fsbraun]

@bartTC Thank you for raising this issue.

Restricting this on DB-Level will not work since snipets can be versioned in principle and there might be several versions of the same snippet.

Looking at the source, I come to think that the lines

djangocms-snippet/src/djangocms_snippet/forms.py

Lines 39 to 40 in 62bb317

	if djangocms_versioning_enabled and is_versioning_installed and snippet_grouper:
	snippet_queryset = snippet_queryset.exclude(snippet_grouper=snippet_grouper)

might be the issue. I believe the exclude should always be applied to the queryset. Am I right in assuming that you do not use versioned snippets?

[bartTC]

That's correct, I'm not using versioning. It's used in a Django CMS 3.x environment.

[fsbraun]

Would you mind testing the branch #177 to see if it works for you?

[bartTC]

I'll check, might take until Friday though.

[bartTC]

@fsbraun this is fixing it! Thank you 👍