Skip to content

Fix tests, add whereIn, whereNotIn and queryCallback support #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

Fix tests, add whereIn, whereNotIn and queryCallback support #8

merged 5 commits into from
Apr 21, 2025

Conversation

willvincent
Copy link

@willvincent willvincent commented Mar 4, 2025 •
edited
Loading

This addresses each of the issues outlined in #7

  1. Adds appropriate number of calls expected to make tests non-risky.
  2. Calls the queryCallback if it's set
  3. Applies wheres, whereIns, and whereNotIns
  4. Proper handling of soft deletes, so that queries work as normal, and with withTrashed() or onlyTrashed() methods chained.

@devNoiseConsulting devNoiseConsulting merged commit d92d5f5 into devNoiseConsulting:master Apr 21, 2025
1 check passed
@devNoiseConsulting
Copy link
Owner

Thanks for these fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvincent @devNoiseConsulting