ECO-11034 | Develop <- 3.3.1 fixes | merge to develop #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop HUBS-2054 | Terraform 3.3.0 | Dev to Main
…/develop HUBS-2563 | Main <- Develop
Uddipaan-Hazarika
requested review from
arunskurian,
elima-sugunan,
kishlay-delphix and
gmanhas23
kishlay-delphix
approved these changes
Nov 29, 2024
elima-sugunan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://delphix.atlassian.net/browse/ECO-11034
This has the fix to database_name issue and vdb_groups issue. Also we aim at fixing the acceptance tests.
Below are the acceptance tests results:
uddipaan.hazarika@Uddipans-MacBook-Pro terraform-provider-delphix % make testacc
TF_ACC=1 go test $(go list ./... | grep -v 'vendor') -v -timeout 120m
? terraform-provider-delphix [no test files]
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN TestDsource_create_positive
--- PASS: TestDsource_create_positive (93.91s)
=== RUN Test_source_create_positive
--- PASS: Test_source_create_positive (67.33s)
=== RUN TestAccEnvironment_positive
--- PASS: TestAccEnvironment_positive (84.74s)
=== RUN TestOracleDsource_create_positive
--- PASS: TestOracleDsource_create_positive (254.09s)
=== RUN TestAccVdb_create_vdb_group_positive
--- PASS: TestAccVdb_create_vdb_group_positive (187.13s)
=== RUN TestAccVdb_provision_positive
--- PASS: TestAccVdb_provision_positive (213.90s)
=== RUN TestAccVdb_bookmark_provision
--- PASS: TestAccVdb_bookmark_provision (465.91s)
=== RUN TestAccVdb_appdata_provision
--- PASS: TestAccVdb_appdata_provision (52.78s)
PASS
ok terraform-provider-delphix/internal/provider 1421.055s
uddipaan.hazarika@Uddipans-MacBook-Pro terraform-provider-delphix % date
Tue Nov 26 19:03:05 IST 2024