fix StaticConstructorLoader decorator #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks reasonable. I will check the PR |
|
@oleg-andreyev please merge the master branch and ignore newly added lines to fix PHPUnit coverage. |
… as ClassLoader and proxies all methods call to target
oleg-andreyev
force-pushed
the
decorator-fix
branch
from
364ccd6 to
8c219bd
Compare
|
@oleg-andreyev rebased. |
|
@oleg-andreyev please fix the coverage, by just ignore the lines of new methods in decorator: |
oleg-andreyev
added a commit
that referenced
this pull request
Jun 10, 2020
oleg-andreyev
added a commit
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19
now StaticConstructorLoader provides same interface/contract as ClassLoader and proxies all methods call to the target