Skip to content

Fix to remove python 2 & python 3 switches using if statements #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

vgali7
Copy link
Contributor

@vgali7 vgali7 commented Jun 26, 2023

No description provided.

@bschoening
Copy link
Contributor

Needs a ↻ Restart Build

@absurdfarce
Copy link
Collaborator

Greetings @vgali7 and thanks for the contribution! I restarted the test run as requested by @bschoening; we'll see if we can reliably reproduce the test failures we saw before.

Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks!

@bschoening
Copy link
Contributor

bschoening commented Jul 6, 2023

Updated appveyor.yml to Python 3.7

@vgali7
Copy link
Contributor Author

vgali7 commented Jul 10, 2023

@absurdfarce Thanks for the tip, I've signed the Contributor License Agreement!

@vgali7
Copy link
Contributor Author

vgali7 commented Jul 19, 2023

@absurdfarce Hey I just wanted to check that this looks good and is ready to commit, thanks! I have some further updates to remove obsolete 'six' compatibility but wanted to get this committed first.

@absurdfarce
Copy link
Collaborator

Hey @vgali7, apologies for not getting back to you sooner. We're in a rush to address some end-of-quarter updates so I haven't taken a look at this in detail yet. I should have more time to look it over in the early part of August.

Thanks for your patience!

@absurdfarce
Copy link
Collaborator

absurdfarce commented Oct 9, 2023

Hey @vgali7, thanks for all the work on this!

It looks like all the changes in here have been merged into #1172 which removes six support as well. Since that PR is a superset of the work done here it probably makes sense to move forward with that. I would encourage you to review (and add comments to) that PR so that we can give it the vigorous review this subject requires.

Thanks again!

@absurdfarce absurdfarce closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants