Skip to content

ulong typedef has been removed in PHP 7.4 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

ulong typedef has been removed in PHP 7.4 #143

merged 1 commit into from
Mar 25, 2020

Conversation

ttraeger
Copy link

ext/php_driver.h Outdated
@@ -117,6 +117,9 @@ typedef zend_object php5to7_zend_object_free;
typedef zval **php5to7_zval_gc;
typedef zval *php5to7_dtor;
typedef size_t php5to7_size;
#if PHP_MAJOR_VERSION >= 7 && PHP_MINOR_VERSION >= 4
Copy link

@stefnats stefnats Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I stumble upon this bug as well when manually compiling (which is necessary for 7.3+).
However, this PR would only fix this for PHP ^7.4 and not 8.0 or above.
Why not change line 120 to

#if ((PHP_MAJOR_VERSION == 7 && PHP_MINOR_VERSION >= 4) || PHP_MAJOR_VERSION > 7)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint, I changed the PR as you suggested.

@mpenick mpenick merged commit ea185de into datastax:master Mar 25, 2020
@mpenick
Copy link
Contributor

mpenick commented Mar 25, 2020

Thanks for the PR!

@stefnats
Copy link

@mpenick currently installing the php cassandra extension is a real pain. When do you think will you tag a new release? Thanks in advance

@adutra
Copy link
Contributor

adutra commented Mar 30, 2020

@stefnats We are preparing a new release, should take us a few weeks. Stay tuned!

@eliasmajic
Copy link

@adutra curious if there is an update

@adutra
Copy link
Contributor

adutra commented Jun 26, 2020

@eliasmajic unfortunately, as I said earlier today on the mailing list, we are not anymore in capacity of resuming the development on the C++ and PHP drivers.

I know how this must be disappointing for you all, but that's the way it is right now. If you can build the driver on your own, that would be your best option currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants