Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

fix unreachable code branches #791

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix unreachable code branches #791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e61815b
fix unreachable code branches
dlawin Dec 6, 2023
ada9306
Merge branch 'master' into unreachable_branch_validate_adjust
dlawin Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data_diff/hashdiff_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _validate_and_adjust_columns(self, table1: TableSegment, table2: TableSegmen
# Update schemas to minimal mutual precision
col1 = table1._schema[c1]
col2 = table2._schema[c2]
if isinstance(col1, PrecisionType) and isinstance(col2, PrecisionType):
if isinstance(col1, PrecisionType):
if strict and not isinstance(col2, PrecisionType):
raise TypeError(f"Incompatible types for column '{c1}': {col1} <-> {col2}")

Expand All @@ -104,7 +104,7 @@ def _validate_and_adjust_columns(self, table1: TableSegment, table2: TableSegmen
table1._schema[c1] = attrs.evolve(col1, precision=lowest.precision, rounds=lowest.rounds)
table2._schema[c2] = attrs.evolve(col2, precision=lowest.precision, rounds=lowest.rounds)

elif isinstance(col1, (NumericType, Boolean)) and isinstance(col2, (NumericType, Boolean)):
elif isinstance(col1, (NumericType, Boolean)):
if strict and not isinstance(col2, (NumericType, Boolean)):
raise TypeError(f"Incompatible types for column '{c1}': {col1} <-> {col2}")

Expand Down