This repository was archived by the owner on May 17, 2024. It is now read-only.
Add pre-commit automation for faster, safer development #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dlawin
force-pushed
the
feature/pre-commit-automation
branch
from
c2ced0e to
2108b3a
Compare
sungchun12
force-pushed
the
feature/pre-commit-automation
branch
from
2108b3a to
839e5e6
Compare
dlawin
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove the friction contributing to
data-diffboth locally and in PRs.Problem: black formatting in the PR adds a bunch of annotations and run time that adds more friction than needed in the pull request workflow. It forces the contributor to click a lot of buttons and run black locally for those, "Oh shoot. I forgot to format!" moments. This adds a couple minutes at a time of frustration which over the course of a month, is a lot of frustration.
Solution:
poetry installandpre-commit install. Ensured line length is constrained to a max line length of 120 given the previous black settings.This wombo combo gives precious time and energy back to the contributor and declutters PRs of those annotations that should just be auto-committed.