make api_version required #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
make-api-version-required
branch
2 times, most recently
from
87a7f36 to
6b8f581
Compare
MarcoGorelli
force-pushed
the
make-api-version-required
branch
from
6b8f581 to
7cc5675
Compare
|
no objections in today's call so let's do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current policy will lead to breakage: #257
The current policy, as far as I can tell, kind of implies that we need perfect backwards compatibility. Or to coordinate multi-year changes across multiple projects, which sounds...really hard
I'd suggest just making
api_versiona required argument. This just simplifies everything