Skip to content

rename get_columns_by_name to select #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Aug 30, 2023

"get_columns_by_name" has been annoying me for a while. Someone has even commented that there's no need to note that this API is developer-focused, as with such an anti-ergonomic name, no user would ever consider using it anyway 😄
Then, the following question from a user has prompted me to finally suggest renaming it:

image

I'm suggesting select because it's already kind of a standardised name:

  • in SQL, you select columns with select
  • pyspark has DataFrame.select
  • polars has DataFrame.select
  • dplyr (R) has select

Q: what about get_column_by_name?

Let's wait until after Thursday's call to discuss this one, depending on the decision that's taken with Column

@MarcoGorelli
Copy link
Contributor Author

this was verbally approved in the last call

if there's no objections, will merge later this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants